QA fix#159
Merged
Merged
Conversation
Added 'Codes' to ValueSet names (that did not contain something like 'type' or 'role' yet) to make sure the names are different from profile names. Also added 'VS' to ValueSet IDs. This is also updated in the suppressed warning. The ValueSet references in the questionnaire must still be updated, but this can't be done here as the valuesets are not used yet.
Change the 'Geboortedatum patiënt' question (linkId 967) from type "dateTime" to "date" in input/resources/Questionnaire-ACP-zib2020.json so only the date (no time) is recorded for patient birthdates.
Update the ValueSet reference in StructureDefinition-ACP-ContactPerson-intro.md to point to ValueSet-ACP-ContactPersonRoleVS.html (was ValueSet-ACP-ContactPersonRole.html). This is a documentation/link fix only.
Collaborator
|
looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.